This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Treat array parameter values as miltivalue parameters#21
Open
urandom wants to merge 3 commits intogooglearchive:masterfrom
Open
Treat array parameter values as miltivalue parameters#21urandom wants to merge 3 commits intogooglearchive:masterfrom
urandom wants to merge 3 commits intogooglearchive:masterfrom
Conversation
Contributor
|
Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide. |
Contributor
|
Thanks for signing the CLA! |
Contributor
|
This needs a test. [https://github.com//pull/25] has some examples of testing core-ajax for a similar change. |
Author
|
I've added a test that checks whether the url contains the expected multi-value parameter I also updated the webcomponents.js script import path, since bower fetched it under webcomponents.js. Not sure if that's correct though |
Contributor
|
I'm working on [https://github.com//pull/40], which will vastly improve the tests in core-ajax. After I get it in, I'll send you a pull request with a test for this case in the WCT style. |
|
I'd like to see this too. Currently there is no way to use multi-value parameters with core-xhr or core-ajax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds the ability to send multivalued parameters, e.g.:
url=foo&url=barby having array values within the params object